docs: add other default disabled instrumentations #11908
Conversation
| @@ -225,6 +225,9 @@ For this reason, the following instrumentations are disabled by default: | |||
| - `jdbc-datasource` which creates spans whenever the `java.sql.DataSource#getConnection` method is called. | |||
| - `dropwizard-metrics` which might create a very low quality metrics data, because of lack of label/attribute support | |||
| in the Dropwizard metrics API. | |||
| - `mybatis` | |||
| - `spring-boot-actuator-autoconfigure` | |||
| - `spring-batch` | |||
There was a problem hiding this comment.
It seems there are other disabled instrumentations that you ignored. Such as micrometer.
You can find all of them by searching public boolean defaultEnabled(ConfigProperties config) { and checking which one's default value is false.
There was a problem hiding this comment.
Not sure whether I should include the internal instrumentations, but I've added all the others in 0c2b870
docs/supported-libraries.md
Outdated
| - `spring-security-config-webflux` | ||
| - `spring-security-config-servlet` |
There was a problem hiding this comment.
I think these two don't really fit here. Although these instrumentations are disabled by default they are enabled when any of otel.instrumentation.common.enduser.id.enabled, otel.instrumentation.common.enduser.role.enabled or otel.instrumentation.common.enduser.scope.enabled is set.
docs/supported-libraries.md
Outdated
| - `spring-security-config-webflux` | ||
| - `spring-security-config-servlet` | ||
| - `jaxrs` | ||
| - `micrometer` |
docs/supported-libraries.md
Outdated
| @@ -225,6 +225,15 @@ For this reason, the following instrumentations are disabled by default: | |||
| - `jdbc-datasource` which creates spans whenever the `java.sql.DataSource#getConnection` method is called. | |||
| - `dropwizard-metrics` which might create a very low quality metrics data, because of lack of label/attribute support | |||
| in the Dropwizard metrics API. | |||
| - `jaxws-jws-api` | |||
| - `mybatis` | |||
| - `spring-boot-actuator-autoconfigure` | |||
There was a problem hiding this comment.
This enables micrometer metric bridging, see #9762
docs/supported-libraries.md
Outdated
| @@ -225,6 +225,15 @@ For this reason, the following instrumentations are disabled by default: | |||
| - `jdbc-datasource` which creates spans whenever the `java.sql.DataSource#getConnection` method is called. | |||
| - `dropwizard-metrics` which might create a very low quality metrics data, because of lack of label/attribute support | |||
| in the Dropwizard metrics API. | |||
| - `jaxws-jws-api` | |||
There was a problem hiding this comment.
jaxws-jws-api, mybatis, spring-ws and jaxrs are disabled because they create only internal spans that don't have any defined semantic conventions
|
@zeitlinger had also proposed the idea of adding this information to the doc site too, if you are interested |
I'll make changes to the site docs as soon as the final version is settled here. |
The current disabled instrumentations section lack multiple instrumentations that has been disabled by default, I've added them to the list, but still need detailed explain why they are disabled.