Fix repeated string serialization for JSON. #6888
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where repeated strings would serialize as the same JSON field multiple times (the same encoding used in binary proto).
This is because in JSON string is a primitive, but not in binary Protocol buffers.
E.g. instead of
stringTable: ["one", "two"],
, we'd getstringTable: "one", stringTable: "two"
.serializeRepeatedString
abstract method which can appropriately handled string arrays in JSON.sizeRepatedString
for solidarity with other methods.For maintainers - This code relies on existing protobuf tests. If you'd like to see the serialization primitives start to have test cases, I'd have to build up a test suite for them but happy to do so.