Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build tooling to support releasing patches, i.e. 1.3.2.1 #18

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

jack-berg
Copy link
Member

Build tooling to release patches when there is no corresponding release from opentelemetry-proto.

For example, to release a patch for 1.3.2:

  • run the release build action
  • Set the release version argument to 1.3.2.1
  • This will publish a release with version 1.3.2.1, but which uses opentelemetry-proto sources from the 1.3.2 release tag

See #17 for more info.

@jack-berg jack-berg requested a review from a team as a code owner September 24, 2024 21:55
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still feels weird, but also seems like a nice compromise given the challenges in keeping the versions somewhat sync'd.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the caveat that I don't fully understand (or like) nebular 🪄 versioning 😄

@jack-berg jack-berg merged commit 835072e into open-telemetry:main Sep 30, 2024
2 checks passed
@jack-berg
Copy link
Member Author

The release was successfully staged to sonatype, but failed to finish publishing: https://github.com/open-telemetry/opentelemetry-proto-java/actions/runs/11111731756/job/30872304418

  • What went wrong:
    Execution failed for task ':release'.
    version should not be set in build file when using nebula-release plugin. Instead use -Prelease.version parameter

So weird for the nebula plugin to partially succeed, only to have a later task reject the way that release.version is specified.

Screenshot 2024-09-30 at 1 37 20 PM

@jack-berg
Copy link
Member Author

Also weird that two artifacts ended up in sonatype: 1.3.2 and 1.3.2.1.

🤔

Obviously I should go and fix this, but I'm also tempted to close (i.e. release) the staged 1.3.2.1 artifact.

@jack-berg jack-berg mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants