Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renovations to experimental profiling schema. #596

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Renovations to experimental profiling schema. #596

merged 1 commit into from
Nov 8, 2024

Conversation

jhalliday
Copy link
Contributor

  • remove Profile keep_frames and drop_frames due to unclear semantics and use cases
  • make Sample.link_index and Location.mapping_index optional, consistent with documented intention
  • remove deprecated fields Sample.location_index, Mapping.id, Location.id, Function.id
  • renumber fields for improved redability

@jhalliday
Renovations to experimental profiling schema.
d80f116 
- remove Profile keep_frames and drop_frames due to unclear semantics and use cases
- make Sample.link_index and Location.mapping_index optional, consistent with documented intention
- remove deprecated fields Sample.location_index, Mapping.id, Location.id, Function.id
- renumber fields for improved redability
@jhalliday jhalliday requested review from a team as code owners November 6, 2024 10:31
@jhalliday
Copy link
Contributor Author

As discussed in the last profiling SIG meeting, this PR removes some unused or problematic fields and clarifies the optional use of others. The substantive changes are smaller than first appear, as the patch also reflows the remaining field numbers for increased clarity, which is somewhat noisy.

felixge
felixge approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🙇

@tigrannajaryan tigrannajaryan merged commit 793e43e into open-telemetry:main Nov 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalexand aalexand aalexand approved these changes

@florianl florianl florianl approved these changes

@petethepig petethepig petethepig approved these changes

@felixge felixge felixge approved these changes

Assignees

@carlosalberto carlosalberto

@tigrannajaryan tigrannajaryan

Labels
spec:profiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jhalliday @felixge @petethepig @florianl @aalexand @carlosalberto @tigrannajaryan