-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in Python 3.13 #4067
Draft
antonpirker
wants to merge
10
commits into
open-telemetry:main
Choose a base branch
from
antonpirker:antonpirker/run-tests-in-python-313
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Run tests in Python 3.13 #4067
antonpirker
wants to merge
10
commits into
open-telemetry:main
from
antonpirker:antonpirker/run-tests-in-python-313
+39
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Currently the show blocker is, that |
Seems like grpc support for 3.13 has been released: grpc/grpc#34922 (comment) |
10 tasks
@antonpirker is there any other blocker for this PR to make it ready for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we run the tests suite against Python 3.13 to see if this works.
I know this is not something we can merge yet, because we probably have to wait until the final Python 3.13 is released. But this PR should be a starting point to see what still needs to be done to make
opentelementry-python
compatible with Python 3.13.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I ran all the test suites using
tox
against Python 3.13 locally. One is still failing:But I guess this is because I need to set
CONTRIB_REPO_SHA
to a commit in the contrib repo that has the Python 3.13 changes in it (which is not possible, because I forked the contrib repo)Does This PR Require a Contrib Repo Change?
Checklist: