Added BatchSpanProcessor metrics on drop and export span #635
+219
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamunto
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
mamunto
commented
Nov 11, 2024
Sources/OpenTelemetrySdk/Trace/SpanProcessors/BatchSpanProcessor.swift
Outdated
Show resolved
Hide resolved
Sources/OpenTelemetrySdk/Trace/SpanProcessors/BatchSpanProcessor.swift
Outdated
Show resolved
Hide resolved
Sources/OpenTelemetrySdk/Trace/SpanProcessors/BatchSpanProcessor.swift
Outdated
Show resolved
Hide resolved
mamunto
force-pushed
the
mdalmamun/add-batch-span-processor-metrics
branch
from
d910005
to
fd4b7e7
Compare
bryce-b
approved these changes
Nov 19, 2024
|
Looks good, I'll approve it after you add the |
mamunto
commented
Nov 20, 2024
Sources/OpenTelemetrySdk/Trace/SpanProcessors/BatchSpanProcessor.swift
Outdated
Show resolved
Hide resolved
bryce-b
reviewed
Nov 20, 2024
Sources/OpenTelemetrySdk/Trace/SpanProcessors/BatchSpanProcessor.swift
Outdated
Show resolved
Hide resolved
mamunto
force-pushed
the
mdalmamun/add-batch-span-processor-metrics
branch
from
4522a0b
to
b41c887
Compare
mamunto
commented
Nov 20, 2024
Comment on lines
+146
to
+157
| deinit { | ||
| // Cleanup all gauge observer | ||
| self.queueSizeGauge?.close() | ||
| self.spanGaugeObserver?.close() | ||
| } |
There was a problem hiding this comment.
Clean up here cc: @bryce-b
| spanList.append(span) | ||
|
|
||
| // If there is any observer before, let's close it | ||
| self.spanGaugeObserver?.close() |
There was a problem hiding this comment.
Clean up if anything present cc: @bryce-b
nachoBonafonte
requested changes
Nov 21, 2024
I followed exactly how it defined in the Java SDK. We can discuss more today's session |
bryce-b
reviewed
Nov 21, 2024
Sources/OpenTelemetryApi/Metrics/Stable/LongCounterBuilder.swift
Outdated
Show resolved
Hide resolved
bryce-b
reviewed
Nov 21, 2024
Sources/OpenTelemetrySdk/Metrics/Stable/LongCounterMeterBuilderSdk.swift
Outdated
Show resolved
Hide resolved
bryce-b
reviewed
Nov 21, 2024
Sources/OpenTelemetrySdk/Metrics/Stable/LongGaugeBuilderSdk.swift
Outdated
Show resolved
Hide resolved
bryce-b
reviewed
Nov 21, 2024
bryce-b
reviewed
Nov 21, 2024
mamunto
force-pushed
the
mdalmamun/add-batch-span-processor-metrics
branch
from
b41c887
to
6e92546
Compare
mamunto
commented
Nov 21, 2024
Comment on lines
+258
to
+272
| extension LongGaugeBuilder { | ||
| public func asLongSdk() throws -> LongGaugeBuilderSdk { | ||
| guard let sdkType = self as? LongGaugeBuilderSdk else { | ||
| throw GuageError.invalidType | ||
| } | ||
| return sdkType | ||
| } | ||
| } | ||
|
|
||
| extension LongCounterBuilder { | ||
| public func asLongSdk() throws -> LongCounterMeterBuilderSdk { | ||
| guard let sdkType = self as? LongCounterMeterBuilderSdk else { | ||
| throw GuageError.invalidType | ||
| } | ||
| return sdkType |
There was a problem hiding this comment.
added helper function here to address the type conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BatchSpanProcessor metrics on drop and export span