Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] build-dev skip registry check, and check-links tweak #5569

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 8, 2024

Followup:

@chalin chalin added the CI/infra CI & infrastructure label Nov 8, 2024
@chalin chalin requested a review from a team as a code owner November 8, 2024 19:00
@chalin
Copy link
Contributor Author

chalin commented Nov 8, 2024

The following failure confirms the fix for detecting when the htmltest config file isn't up-to-date: https://github.com/open-telemetry/opentelemetry.io/actions/runs/11747969686/job/32731050098?pr=5569:

image

I'll update it now. Let me try via a /fix command. Oh no, of course, that won't work!

@chalin
Copy link
Contributor Author

chalin commented Nov 8, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11748075874

@chalin chalin force-pushed the chalin-im-ci-cmd-fixes-2024-11-08 branch from 1ea4810 to c9d4af8 Compare November 8, 2024 19:11
@opentelemetrybot opentelemetrybot requested review from a team November 8, 2024 19:11
@opentelemetrybot
Copy link
Collaborator

fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11748075874.

@chalin chalin added the i18n internationalization label Nov 8, 2024
@chalin chalin force-pushed the chalin-im-ci-cmd-fixes-2024-11-08 branch from c9d4af8 to 0943d57 Compare November 8, 2024 19:20
@chalin chalin force-pushed the chalin-im-ci-cmd-fixes-2024-11-08 branch from 6fa6d4c to 491d92c Compare November 8, 2024 19:42
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@chalin chalin merged commit 9e32936 into open-telemetry:main Nov 8, 2024
17 checks passed
@chalin chalin deleted the chalin-im-ci-cmd-fixes-2024-11-08 branch November 8, 2024 19:47
@chalin
Copy link
Contributor Author

chalin commented Nov 8, 2024

A successful run of the new fix:htmltest-config command: #5571 (comment)

@chalin chalin changed the title [CI] build-dev skip registry check and check-links tweak [CI] build-dev skip registry check, and check-links tweak Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n internationalization lang:fr
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants