-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make runtime multiplatform compatible #168
Merged
andrewparmet
merged 447 commits into
open-toast:main
from
andrewparmet:make-runtime-multiplatform-compatible
Sep 28, 2023
Merged
Make runtime multiplatform compatible #168
andrewparmet
merged 447 commits into
open-toast:main
from
andrewparmet:make-runtime-multiplatform-compatible
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewparmet
force-pushed
the
make-runtime-multiplatform-compatible
branch
from
October 1, 2022 04:43
c780ec7
to
ffe7efd
Compare
ogolberg
reviewed
Sep 6, 2023
ogolberg
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
api
configuration.I got this working with this fork of the protobuf-gradle-plugin. Definitely a hack.ORG_GRADLE_PROJECT_mavenCentralUsername
andORG_GRADLE_PROJECT_mavenCentralPassword
. Can't get the Gradle properties version to work.except that mysteriously the compiler sometimes doesn't resolve calls to the function and instead thinks we're calling the private constructor. https://youtrack.jetbrains.com/issue/KT-52492/Inconsistent-overload-resolution-between-function-and-constructofixedUsed lower case letters for now. Even with lower case functions the compiler sometimes can't resolve them or throws NoSuchMethodError - makes me think there's a problem in the Gradle config or something having to do with top level functions. Capital letter functions could possibly work with a strategy like this:Exposing a constructor like this probably breaks easy Jackson integration, but we should probably discourage that anyways.
protokt.proto
is not propagating through extract-include-protos properly.Unrelated proposed changes for 1.0:
Change extension wrapper API to work on Sequence instead of cloning ByteArray.Use read-only views of Bytes directly.