-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change event_payload column size from TEXT to MEDIUMTEXT #16751
base: master
Are you sure you want to change the base?
Change event_payload column size from TEXT to MEDIUMTEXT #16751
Conversation
This change was missing when the payload colum size of table events was changed.
e0749f5
to
a0a624f
Compare
while I think this change is a good step in the right direction ... might i suggest a follow up PR which basically adds some exception handling so that it can skip over such events and try requests further down the list? and maybe some influxdb metric that tells us about failed notifications. |
This was a first and fast approach to solve the issue of not creating notifications. I put this PR in draft, and will think in a better solution. |
Yeah delayed_job is not too smart about low level failures. I'm sure this will come up in the RCA :)
We already measure everything about this, including alerts. They just fired when no one was there anymore... https://obs-measure.opensuse.org/d/SKLo7evMk/emails?orgId=1 |
TBH making all the tables use the same size for the columns is good. i was just thinking how we can handle this better if similar errors show up in the future. |
This change was missing when the payload colum size of table events was changed.
Related to #15649.