Show available creator filter options after filter is applied #17040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoj
reviewed
Oct 30, 2024
Before after filtering by a creator, the rest of the available creators disappeared from the filter dropdown and only the selected one's remained in the list. This happend because the list of creators in the filter dropdown was basedon the requests where the creator filter was already applied. We have to set the available creators before applying the filter it self in order to keep the list complete.
krauselukas
force-pushed
the
request_index/consistent_filter_behaviour
branch
from
a69c96a
to
5938a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before after filtering by a creator, the rest of the available creators disappeared from the filter dropdown and only the selected one's remained in the list.
This happend because the list of creators in the filter dropdown was basedon the requests where the creator filter was already applied. We have to set the available creators before applying the filter it self in order to keep the list complete.
Before:
After:
