Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing multi-stage build workflow #2445

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alaxalves
Copy link

@alaxalves alaxalves commented Mar 19, 2019

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works(if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves/which issues does this fix?:

  • I have implemented a better flow to docker builds as recommended here

Changes proposed in this pull request:

  • Uses the base image a stage build, thus shortening the img size.

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #2445 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2445   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         146      146           
  Lines        4760     4760           
=======================================
  Hits         3933     3933           
  Misses        827      827

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0197ed3...6c23522. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #2445 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2445   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         146      146           
  Lines        4760     4760           
=======================================
  Hits         3933     3933           
  Misses        827      827

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0197ed3...6c23522. Read the comment docs.

@Ana06 Ana06 requested a review from hennevogel March 22, 2019 10:29
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alaxalves! 💐

@hennevogel can you please take a look? 🙏

@Ana06
Copy link
Member

Ana06 commented Jun 13, 2019

@hennevogel ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants