Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access to the version history of organization-level roles #2654

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix access to the version history of organization-level roles #2654

wants to merge 4 commits into from

Commits on May 20, 2023

  1. Remove unused code

    @AndrewKvalheim
    AndrewKvalheim committed May 20, 2023
    Configuration menu
    Copy the full SHA
    de24d4a View commit details
    Browse the repository at this point in the history

  2. Test access to organization_admin version as organization_admin 

    This corrects the specification for the behavior of the Revision History
screen; changes to the organization administrator role should be
accessible to organization administrators, not conference organizers.
    @AndrewKvalheim
    AndrewKvalheim committed May 20, 2023
    Configuration menu
    Copy the full SHA
    4dd15d6 View commit details
    Browse the repository at this point in the history

  3. Grant permission to read, revert organization_admin version 

    Without this permission, organization administrators can't see the
history of changes to the organization administrator role on the
Revision History screen.
    @AndrewKvalheim
    AndrewKvalheim committed May 20, 2023
    Configuration menu
    Copy the full SHA
    150bbef View commit details
    Browse the repository at this point in the history

  4. Deconflate organization/conference IDs in role versions 

    Resolves failing test spec/features/versions_spec.rb:321

Partially reverts 81853d1
    @AndrewKvalheim
    AndrewKvalheim committed May 20, 2023
    Configuration menu
    Copy the full SHA
    3f6a9e9 View commit details
    Browse the repository at this point in the history