Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/restore users events edit views #3073

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mkiroshdz
Copy link
Contributor

@mkiroshdz mkiroshdz commented Jul 20, 2022

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works(if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves/which issues does this fix?:

This PR restores the admin views for new events and edit users in order to fix #2975

Changes proposed in this pull request:

  • Restore admin/users#edit view.
  • Restore admin/events#new view.

@AndrewKvalheim
Copy link
Member

AndrewKvalheim commented Sep 13, 2022

Thanks for putting this together. I’ve just pulled up a snapshot of the previous forms for comparison:

Previous (3bbbdb4) Proposed (306b1f1d)
3bbbdb4 /admin/users/2/edit 306b1f1d /admin/users/2/edit
3bbbdb4 /admin/conferences/example/program/events/new 306b1f1d /admin/conferences/example/program/events/new

There are a few differences, but I’m not sure what parts matter as I don’t have any experience actually using OSEM.

I drafted minimal tests that pass with this PR, but I don’t know if they’re the right kind of test for these forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing templates for admin forms
3 participants