Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored conferences controller, dividing responsabilities using an… #3102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carlosdanielpohlod
Copy link

… service and an query

Checklist

  • [ x ] I have read the Contribution & Best practices Guide.
  • [ x ] My branch is up-to-date with the upstream master branch.
  • [ x ] The tests pass locally with my changes.
  • [x ] I have added tests that prove my fix is effective or that my feature works(if appropriate).
  • I have added necessary documentation (if appropriate).

This PR refactors the show method into conferences_controller, moving some logic to a service and a query to separate better the responsibilities and improve the controller code legibility.

This commit is an refactor of #3037

Changes proposed in this pull request:

@carlosdanielpohlod
Copy link
Author

@hennevogel

@hennevogel hennevogel force-pushed the backend/refactor/conferences_controller_show branch from 0248f72 to 51541cc Compare April 19, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants