Changes to effect Issue2707 #3112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a paragraph telling if there is no upcoming conference, and also hiding add to event calendar button if there is no conference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE #2707 , Adding a paragraph telling if there is no upcoming conference, and also hiding add to event calendar button if there is no conference.
Thank you in advance for considering this pull request, it is my first attempted OSS contribution to a large project. Tried to keep it as small as I can and only touched the view.
Checklist
masterbranch.Short description of what this resolves/which issues does this fix?:
-Issue 2707
Changes proposed in this pull request:
Currently if there are no conferences the index view appears blank. This was pointed out that this could potentially confuse someone who maybe believes there has been a data error, and the conferences have been dropped. If current conferences is empty it seems easy to make these changes in the view file only to show the paragraph and hide the events button to resolve this issue.