Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop-rails 2.24.1 → 2.26.0 (minor) #3450

Closed
wants to merge 1 commit into from
Closed

Update rubocop-rails 2.24.1 → 2.26.0 (minor) #3450

wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Aug 31, 2024

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.24.1 → 2.26.0) · Repo · Changelog

Release Notes

2.26.0

New features

Bug fixes

  • #1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. (@earlopain)
  • #1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. (@earlopain)
  • #1337: Fix an error for Rails/Validation when passing no arguments. (@earlopain)
  • #1330: Fix an error for Rails/WhereNot when using placeholder without second argument. (@earlopain)
  • #1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. (@tldn0718)
  • #1313: Fix false positives for Rails/CompactBlank when using collection.reject!. (@koic)
  • #1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. (@earlopain)
  • #1306: Make Rails/PluralizationGrammar aware of byte methods. (@earlopain)
  • #1302: Allow params receiver by default for Style/CollectionMethods. (@koic)
  • #1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). (@earlopain)

Changes

  • #1308: Change Rails/CompactBlank to handle select(&:present?). (@fatkodima)
  • #1303: Change Rails/IgnoredSkipActionFilterOption to handle multiple callbacks. (@fatkodima)
  • #1199: Make Rails/WhereEquals aware of where.not(...). (@earlopain)
  • #1003: Change Rails/RootPathnameMethods to detect offenses on Dir.[]. (@r7kamura)

2.25.1

Bug fixes

  • #1280: Look for change_column_null for Rails/BulkChangeTable. (@ccutrer)
  • #1299: Fix an error for Rails/NotNullColumn when the block for change_table is empty. (@earlopain)
  • #1281: Fix Rails/WhereRange autocorrect for complex expressions. (@fatkodima)
  • #1282: Fix Rails/WhereRange to correctly handle template strings with extra spaces. (@fatkodima)

Changes

  • #1295: Cover validates_comparison_of in Rails/Validation. (@ChaelCodes)
  • #1288: Let Rails/LinkToBlank look into link_to_if and link_to_unless, too. (@fwolfst)
  • #1286: Mark Rails/SkipsModelValidations as unsafe. (@koic)
  • #1283: Mark Rails/WhereRange as unsafe autocorrect. (@fatkodima)

2.25.0

New features

Bug fixes

  • #1270: Fix an incorrect autocorrect for Rails/Validation when using validates_size_of. (@koic)
  • #1278: Fix a false positive for Rails/SkipsModelValidations when using insert or insert! with a safe navigator. (@tldn0718)
  • #1260: Fix a performance regression caused by Rails/UnknownEnv when using Rails 7.1. (@lukasfroehlich1)

Changes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (1.65.0 → 1.65.1) · Repo · Changelog

Release Notes

1.65.1

New features

  • #13068: Add config validation to Naming/PredicateName to check that all ForbiddenPrefixes are being checked. (@maxjacobson)

Bug fixes

  • #13051: Fix an error for Lint/FloatComparison when comparing with rational literal. (@koic)
  • #13065: Fix an error for Lint/UselessAssignment when same name variables are assigned using chained assignment. (@koic)
  • #13062: Fix an error for Style/InvertibleUnlessCondition when using empty parenthesis as condition. (@earlopain)
  • #11438: Explicitly load fileutils before calculating before_us. (@r7kamura)
  • #13044: Fix false negatives for Lint/ImplicitStringConcatenation when using adjacent string interpolation literals on the same line. (@koic)
  • #13083: Fix a false positive for Style/GlobalStdStream when using namespaced constants like Foo::STDOUT. (@earlopain)
  • #13081: Fix a false positive for Style/ZeroLengthPredicate when using safe navigation and non-zero comparison. (@fatkodima)
  • #13041: Fix false positives for Lint/UselessAssignment when pattern match variable is assigned and used in a block. (@koic)
  • #13076: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when using hash value omission. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 41 commits:

↗️ parallel (indirect, 1.25.1 → 1.26.3) · Repo

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ parser (indirect, 3.3.4.0 → 3.3.4.2) · Repo · Changelog

Release Notes

3.3.4.1 (from changelog)

API modifications:

  • Bump 3.2 branch to 3.2.5. (#1036) (Ilya Bylich)
  • Bump Racc to 1.8.1 (#1031) (Koichi ITO)

Bugs fixed:

  • builder.rb: catch encoding errors when parsing invalid encoding regexp (#1033) (Earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 11 commits:

↗️ rubocop-ast (indirect, 1.31.3 → 1.32.1) · Repo · Changelog

Release Notes

1.32.1 (from changelog)

Changes

  • #309: Mark RuboCop::AST::EnsureNode as being in a void context. (@earlopain)

1.32.0 (from changelog)

New features

  • #304: Add RuboCop::AST::RationalNode. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 23 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu Automatic PRs to update gems label Aug 31, 2024
@depfu depfu bot mentioned this pull request Aug 31, 2024
Closed
@depfu Depfu
Copy link
Contributor Author

depfu bot commented Sep 28, 2024

Closed in favor of #3453.

@depfu depfu bot closed this Sep 28, 2024
@depfu depfu bot deleted the depfu/update/rubocop-rails-2.26.0 branch September 28, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu Automatic PRs to update gems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants