This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
TDX: add dbs-tdx crate #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
studychao
force-pushed
the
chao/add_dbs_tdx
branch
from
dbb4c97
to
ca06c4a
Compare
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 91.59% 90.42% -1.17%
==========================================
Files 80 82 +2
Lines 22405 24596 +2191
==========================================
+ Hits 20521 22240 +1719
- Misses 1884 2356 +472
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
studychao
force-pushed
the
chao/add_dbs_tdx
branch
from
910eb03
to
79bbb51
Compare
We will first add tdx-ioctls for dbs-tdx. Signed-off-by: fengshifang <[email protected]> Signed-off-by: Chao Wu <[email protected]>
studychao
force-pushed
the
chao/add_dbs_tdx
branch
from
612a7a1
to
4625b0e
Compare
wllenyj
reviewed
Feb 14, 2023
crates/dbs-tdx/src/tdx_ioctls.rs
Outdated
| // | ||
| // SPDX-License-Identifier: Apache-2.0 OR BSD-3-Clause | ||
| // | ||
| #![allow(missing_docs)] |
wllenyj
reviewed
Feb 14, 2023
| } | ||
|
|
||
| /// Initialize TDX vcpu | ||
| pub fn tdx_init_vcpu(vcpu_fd: &RawFd, hob_address: u64) -> std::result::Result<(), TdxIoctlError> { |
NK-fengsf
reviewed
Feb 15, 2023
| #[repr(C)] | ||
| #[derive(Default)] | ||
| /// Tdx capabilities. | ||
| pub struct TdxCapabilities { |
There was a problem hiding this comment.
Add documention for struct TdxCapabilities
|
This crate may be used temporarily，the related function may be implemented in rust-vmm/kvm-ioctls after tdx is supported in upstream guest kernel. |
Since we add document to all pub elements, we could remove allow missing doc now. Signed-off-by: Chao Wu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will first add tdx-ioctls for dbs-tdx.
Signed-off-by: fengshifang [email protected]
Signed-off-by: Chao Wu [email protected]