This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
vsock: passthrough fd support for hybrid mode #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 90.42% 90.02% -0.40%
==========================================
Files 82 80 -2
Lines 24596 23822 -774
==========================================
- Hits 22240 21445 -795
- Misses 2356 2377 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@lifupan Can you fix the clippy? |
Done! |
ZizhengBian
reviewed
Jul 2, 2023
lifupan
force-pushed
the
main
branch
2 times, most recently
from
048b3a9
to
3801bea
Compare
ZizhengBian
reviewed
Jul 11, 2023
lifupan
force-pushed
the
main
branch
2 times, most recently
from
b894667
to
49b6bcc
Compare
After applying this commit, the hybrid vsock would support two types of connections: 1) pass "CONNECT <port>\n" to the hybrid unix socket; 2) pass "PASSFD\n" to the hybrid unix socket first, then, using sendmsg and msg_control to pass the <port> number and fd to the unix socket. In both of the cases, you should read on the socket to get a response of "OK <assigned_hostside_port>\n". Signed-off-by: fupan <[email protected]>
studychao
approved these changes
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After applying this commit, the hybrid vsock would support two types of connections:
then, using sendmsg and msg_control to pass the
number and fd to the unix socket.
In both of the cases, you should read on the socket to get a response of "OK <assigned_hostside_port>\n".