dbs-virtio-devices: fix Balloon::write_config() bugs #290
Conversation
|
See also firecracker-microvm/firecracker#3869 |
ZizhengBian
force-pushed
the
dbs-virtio-devices/balloon
branch
from
abbc1bb
to
6f24a1f
Compare
|
Please fix ut/clippy |
|
@00xc Hi, could you please help fix the UT before this week since we are going to migrate all dbs crates to kata containers next week. |
00xc
force-pushed
the
dbs-virtio-devices/balloon
branch
from
6f24a1f
to
24351b8
Compare
|
Should be good now |
1. Fix potential integer overflow when calculating the end of the write destination (`offset + data_len`). 2. Fix a potential panic when copying into the destination slice due to size mismatch. Signed-off-by: Carlos López <[email protected]>
00xc
force-pushed
the
dbs-virtio-devices/balloon
branch
from
f24796c
to
793206a
Compare
|
@00xc There seems several clippy warnings please help fix it. Tip: we are using Rust 1.70. |
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 90.42% 90.05% -0.37%
==========================================
Files 82 69 -13
Lines 24596 22047 -2549
==========================================
- Hits 22240 19855 -2385
+ Misses 2356 2192 -164
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Those warnings popped up on code completely unrelated to this PR. I have fixed them, but that seems like a very unusual request. |
Signed-off-by: Carlos López <[email protected]>
00xc
force-pushed
the
dbs-virtio-devices/balloon
branch
from
ca956ff
to
da70713
Compare
The new device is public but behind a private module. Add a `pub use` for the exports of the module. Signed-off-by: Carlos López <[email protected]>
|
@00xc , sorry, after dig into the reason for CI complaining for the code not in your PR, we found out that there is one PR merged without clippy pass. Do you mind fix that in this PR or I could raise a new PR to fix this ? |
|
@00xc Hi, the PR itself looks good to me. I'll handle the clippy warnings. |
Thanks! |
Fix two bugs in
Balloon::write_config():offset + data_lenmight overflow. This causes a panic in debug builds, and wraps around in release builds.dragonball-sandbox/crates/dbs-virtio-devices/src/balloon.rs
Line 634 in 8ed5e3f
data) and destination (right) slices' sizes might be mismatched inright.copy_from_slice(data), which causes a panic (this is documented). This can happen ifdatais shorter than the right side ofconfig_slice.split_at_mut(offset):dragonball-sandbox/crates/dbs-virtio-devices/src/balloon.rs
Lines 638 to 640 in 8ed5e3f