Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created time rules #156

Merged
merged 2 commits into from
Aug 20, 2014
Merged

Created time rules #156

merged 2 commits into from
Aug 20, 2014

Conversation

sebastianruder
Copy link
Contributor

Should not be merged yet.

@amebel
Copy link
Contributor

amebel commented Aug 19, 2014

@williampma i fetched this PR and run the sentence "She went home before I left" and the rule is not in the output, would you pls check that. Thanks !

@williampma
Copy link
Member

Did you recompile with the fix I created at #157 ? It works on my end

(before-after-rule (get-instance-name "go" "went@8c326a46-3786-4c55-a79a-d150ca5eb595" (ParseNode "sentence@91c91ba9-d832-41c9-aea0-313919c0501b_parse_0")) (get-instance-name "leave" "left@61b09afa-6566-4c2b-9759-565223fb3832" (ParseNode "sentence@91c91ba9-d832-41c9-aea0-313919c0501b_parse_0")) "verb" "before")

@amebel
Copy link
Contributor

amebel commented Aug 19, 2014

Thanks, i rebased the PR and it worked .

@williampma
Copy link
Member

With regards to the missing _time(pm, 6) mentioned in #124, I got the following error from one of the RelationCallback when using plain-text-server.sh (probably from SimpleView or NLGInputView)

Error: No target! rel=_time and src=pm

so maybe number "6" is not set to "name"? @linas , @rodsol

@amebel
Copy link
Contributor

amebel commented Aug 19, 2014

i am working on a fix now

On Tue, Aug 19, 2014 at 3:44 PM, William Ma [email protected]
wrote:

With regards to the missing _time(pm, 6) mentioned in #124
#124, I got the following error
from one of the RelationCallback when using plain-text-server.sh (probably
from SimpleView or NLGInputView)

Error: No target! rel=_time and src=pm

so maybe number "6" is not set to "name"? @linas
https://github.com/linas , @rodsol https://github.com/rodsol


Reply to this email directly or view it on GitHub
#156 (comment).

amebel added a commit that referenced this pull request Aug 20, 2014
@amebel amebel merged commit afc354c into opencog:master Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants