Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modification on Extrapositions #25

Merged
merged 1 commit into from
May 6, 2014
Merged

modification on Extrapositions #25

merged 1 commit into from
May 6, 2014

Conversation

rodsol
Copy link
Contributor

@rodsol rodsol commented May 6, 2014

Fix on Extrapositions . For sentences like

   -" I like the trees which have coffee beans."
  - "Just before the crossroads, the car was stopped by a traffic sign that stood on the street."

linas added a commit that referenced this pull request May 6, 2014
modification on Extrapositions
@linas linas merged commit 9eb472d into opencog:master May 6, 2014
@linas
Copy link
Member

linas commented May 6, 2014

Hi Rodas,

Did you run the unit tests after these changes? I'm getting that 5 out of 15 of the extraposition tests failed, and both comparative tests failed ...

@rodsol
Copy link
Contributor Author

rodsol commented May 6, 2014

yeah there are 13 sentences for extraposition and the test passed OK... but
for the comparative it failed

On Tue, May 6, 2014 at 6:24 PM, Linas Vepstas [email protected]:

Hi Rodas,

Did you run the unit tests after these changes? I'm getting that 5 out of
15 of the extraposition tests failed, and both comparative tests failed ...


Reply to this email directly or view it on GitHubhttps://github.com//pull/25#issuecomment-42316950
.

@linas
Copy link
Member

linas commented May 6, 2014

what version of link-grammar are you running?

Also: check your numbers there are 15 tests not 13 ... we should move this conversation over to bug #26 for this

@rodsol
Copy link
Contributor Author

rodsol commented May 6, 2014

Ok ,maybe the problem is on link-grammar version am using the older
version(version 4.8.2).

in the unit test there are 13 sentence for extraposition and 2 sentence
for comparatives

and the test pass for extraposition

On Tue, May 6, 2014 at 6:36 PM, Linas Vepstas [email protected]:

what version of link-grammar are you running?

Also: check your numbers there are 15 tests not 13 ... we should move this
conversation over to bug #26 https://github.com/opencog/relex/issues/26for this


Reply to this email directly or view it on GitHubhttps://github.com//pull/25#issuecomment-42318527
.

@linas
Copy link
Member

linas commented May 6, 2014

Ahh, right, yest there are 13. So then the new failures are due to the newer link-grammar. Hmmm

@rodsol rodsol deleted the r2l branch May 7, 2014 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants