Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ml to opencv_contrib #151

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

kaingwade
Copy link
Contributor

Delete the accuracy test of ml, since it is moved to opencv_contrib from 5.0.

@kaingwade
Copy link
Contributor Author

@fengyuentau Can you take a look?

@fengyuentau
Copy link
Member

There is a failed test from videoio module, which I believe is not relavent.

# videoio
[ RUN      ] Media.audio/0, where GetParam() = ("test_audio.mp4", 1, 0.15, 64, 240, 320, 90, 132299, 30, 30, GSTREAMER)

(opencv_test_videoio:12825): GStreamer-WARNING **: 14:37:17.822: Name 'uridecodebin3' is not unique in bin 'pipeline8', not adding
[ WARN:[email protected]] global cap_gstreamer.cpp:1750 open OpenCV | GStreamer warning: frame count is estimated by duration and fps
[ WARN:[email protected]] global cap_gstreamer.cpp:1939 getProperty OpenCV | GStreamer: CAP_PROP_AUDIO_SHIFT_NSEC property is not supported
video0 timestamp: 0.0522449  audio0 timestamp: 0.0522449 (audio shift nanoseconds: 0 , seconds: 0)
frame=0:  audioFrameSize=1470  videoTimestamp=52.2449 ms
frame=1:  audioFrameSize=1470  videoTimestamp=78.3673 ms
frame=2:  audioFrameSize=1470  videoTimestamp=104.49 ms
frame=3:  audioFrameSize=1470  videoTimestamp=156.735 ms
frame=4:  audioFrameSize=1470  videoTimestamp=182.857 ms
frame...
frame=85:  audioFrameSize=1470  videoTimestamp=2873.47 ms
frame=86:  audioFrameSize=1470  videoTimestamp=2899.59 ms
frame=87:  audioFrameSize=1470  videoTimestamp=2951.84 ms
frame=88:  audioFrameSize=1470  videoTimestamp=2977.96 ms
frame=89:  audioFrameSize=0  videoTimestamp=2966.67 ms
Total audio samples=130829
/home/ci/opencv/modules/videoio/test/test_audio.cpp:46: Failure
Expected equality of these values:
  numberOfSamples
    Which is: 13[229](https://github.com/opencv/ci-gha-workflow/actions/runs/7974826258/job/21771615014?pr=151#step:31:230)9
  audioData[nCh].size()
    Which is: 130829
nCh=0
[  FAILED  ] Media.audio/0, where GetParam() = ("test_audio.mp4", 1, 0.15, 64, [240](https://github.com/opencv/ci-gha-workflow/actions/runs/7974826258/job/21771615014?pr=151#step:31:241), 320, 90, 132299, 30, 30, GSTREAMER) (143 ms)

Also a time-out error https://github.com/opencv/ci-gha-workflow/actions/runs/7974826252/job/21771615907?pr=151 which is networking problem.


@asmorkalov Please note that this PR needs to be merged before the source code removal so as not to break CI.

@kaingwade Please also submit another PR to add back these ml tests and merge it after the source code removal from main repo and before the merge of the PR in contrib which adds back the module.

@asmorkalov asmorkalov self-requested a review February 27, 2024 05:15
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 197120b into opencv:main Feb 27, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants