Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cross-OS way to delete build output #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeroenheijmans
Copy link

Fixes #175

Saw #175 come by in my feed. Have successfully solved this with the rimraf npm package which is one of the suggestions in the top Stack Overflow post on the subject, but I personally agree with the lower voted answer that for such a simple task using a package with less dependencies seems preferable.

I've tested this on my Windows 10 machine, not yet on any Linux VM (nor did I see any CI or GitHub actions in this repo to verify it?). Will first see what the maintainers think of this approach.

If you don't like this approach: no harm done! Your call.

(I realize the title of #175 is "Powershell support", but I took it to be in general about cross-OS and cross-shell support. It should also work with cmd, right?)

@kaelig
Copy link

kaelig commented Apr 10, 2021

👋 This approach is creative, but comes at the expense of obscuring the intent behind the code.

My 2c: shx and rimraf would be more idiomatic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Powershell support
2 participants