8341168: Cleanup dead code after JDK-8322630

[xmas92]

JDK-8322630 / #17495 removed the the concept of ICStubs, InlineCache buffers and related safepoints.

There are a handfull of references and auxiliary constructs still in the code, I propose we clean these out.

This removes the unused:

• Experimental InlineCacheBufferSize option
• InlineCacheBuffer_lock mutex
• Thread::_missed_ic_stub_refill_verifier field
• VM_ICBufferFull VM operation

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341168: Cleanup dead code after JDK-8322630 (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer) Review applies to 3c6758dd
• Thomas Schatzl (@tschatzl - Reviewer)
• Hamlin Li (@Hamlin-Li - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21255/head:pull/21255
$ git checkout pull/21255

Update a local copy of the PR:
$ git checkout pull/21255
$ git pull https://git.openjdk.org/jdk.git pull/21255/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21255

View PR using the GUI difftool:
$ git pr show -t 21255

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21255.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341168: Cleanup dead code after JDK-8322630

Reviewed-by: stefank, tschatzl, mli, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 988a531: 8340181: Shenandoah: Cleanup ShenandoahRuntime stubs
• 822a773: 8340605: Open source several AWT PopupMenu tests
• 6514aef: 8340419: ZGC: Create an UseLargePages adaptation of TestAllocateHeapAt.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xmas92 The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (6fb323b2)
• 00: Full (3c6758dd)

[stefank]

Looks good, but one small nit.

[stefank]

This is interesting. The StubQueue seems to work against an interface and that interface used to have two implementing classes. Now that one of the is gone, we might want to reconsider if we need this interface. There seems to be a lot of code that could be remove in this area. See DEF_STUB_INTERFACE and how it is being used.

[shipilev]

OK, looks fine.

[xmas92]

Thanks for the reviews.
/integrate

[openjdk]

Going to push as commit ad5ffcc.
Since your change was applied there have been 22 commits pushed to the master branch:

• 1b46fea: 8341024: [test] build/AbsPathsInImage.java fails with OOM when using ubsan-enabled binaries
• 9bd4785: 8340437: Open source few more AWT Frame related tests
• 988f13a: 8340354: Open source AWT desktop properties and print related tests
• b11066b: 8340719: Open source AWT List tests
• a32c3b4: 8340407: Open source a few more Component related tests
• 31858fc: 8340491: Thread stack-base assertion should report which thread has the un-set stack
• bfdeb33: 8340332: Open source mixed AWT tests - Set3
• a6b3188: 8337632: AES-GCM Algorithm optimization for x86_64
• 5586f83: 8341064: Define anchor point and index term for "wrapper classes"
• 4168faf: 8341100: Add index entries for terms used in java.lang.Class
• ... and 12 more: https://git.openjdk.org/jdk/compare/ae4d2f15901bf02efceaac26ee4aa3ae666bf467...master

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit ad5ffcc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.