8341176: Permit access to diagnostics for transient snippets

[lahodaj]

JShell permits to create transient snippets using SourceCodeAnalysis.sourceToSnippets, for the purpose of alternative UI clients. But, the alternative UI clients might need to get the diagnostics for the snippets, but the existing JShell.diagnostics(Snippet) will not work for the transient snippets.

This patch proposes to enhance the JShell.diagnostics(Snippet) with an ability to return best-effort diagnostics for these transient snippets.

Please also review the CSR:
https://bugs.openjdk.org/browse/JDK-8341200

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8341200 to be approved

Issues

• JDK-8341176: Permit access to diagnostics for transient snippets (Enhancement - P3)
• JDK-8341200: Permit access to diagnostics for transient snippets (CSR)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21261/head:pull/21261
$ git checkout pull/21261

Update a local copy of the PR:
$ git checkout pull/21261
$ git pull https://git.openjdk.org/jdk.git pull/21261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21261

View PR using the GUI difftool:
$ git pr show -t 21261

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21261.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341176: Permit access to diagnostics for transient snippets

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 597 new commits pushed to the master branch:

• 44ec501: 8305895: Implement JEP 450: Compact Object Headers (Experimental)
• 6053962: 8343684: Test KDFDelayedProviderSyncTest.java intermittent fails didn't finish within the time-out 150
• 2fb0c1d: 8343844: Add benchmarks for superword/autovectorization in FFM BulkOperations
• 72f67fb: 8343411: Test fail on Windows due to "An established connection was aborted by the software in your host machine"
• 7d6a2f3: 8342860: Fix more NULL usage backsliding
• f6edfe5: 8343506: [s390x] multiple test failures with ubsan
• 96eed7f: 8343306: javac is failing to determine if a class and a sealed interface are disjoint
• 0c281ac: 8343754: Problemlist jdk/jfr/event/oldobject/TestShenandoah.java after JDK-8279016
• 2e58ede: 8341399: Add since checker tests to the langtools modules
• c7f071c: 8343189: [REDO] JDK-8295269 G1: Improve slow startup due to predictor initialization
• ... and 587 more: https://git.openjdk.org/jdk/compare/ae4d2f15901bf02efceaac26ee4aa3ae666bf467...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a8017a8c)

[bridgekeeper]

@lahodaj This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[vicente-romero-oracle]

lgtm

[lahodaj]

/integrate

[openjdk]

Going to push as commit 5ca6698.
Since your change was applied there have been 613 commits pushed to the master branch:

• a93bd9d: 8343810: [s390x] is_uimm* methods should take unsigned arguments
• f12c370: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html
• ae6bb3c: 8343824: Remove unused InstructionFlags in C1
• 5b2f7f3: 8343837: Remove unnecessary reinterpret_cast from C2AccessValuePtr
• 5f338e9: 8342946: Replace predicate walking code in Loop Unrolling with a predicate visitor
• e1d684c: 8342650: Move getChars to DecimalDigits
• ca69a53: 8211033: Clean up the processing -classpath argument not to set LM_CLASS
• 7b0f273: 8343894: ProblemList javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java
• 74ae3c6: 8343650: Reuse StringLatin1::putCharsAt and StringUTF16::putCharsAt
• 423e8e0: 8339162: [REDO] JDK-8338440 Parallel: Improve fragmentation mitigation in Full GC
• ... and 603 more: https://git.openjdk.org/jdk/compare/ae4d2f15901bf02efceaac26ee4aa3ae666bf467...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 5ca6698.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.