Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move nmethods relocInfo data to C heap #21276

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bulasevich
Copy link
Contributor

@bulasevich bulasevich commented Oct 1, 2024

Benchmark              Mode  Cnt    Score   Error  Units
JmhDotty.runOperation    ss   13  799.173 ± 8.989  ms/op

Statistics for 366 native nmethods:
 N. total size  = 214832
 N. relocation  = 6696
 N. main code   = 99604
 N. oops        = 352
 N. metadata    = 16
Statistics for 21054 bytecoded nmethods for C1:
 total size      = 111065192 (100%)
 in CodeCache    = 72805904 (65.552406%)
   header        = 5221392 (7.171660%)
   relocation    = 6663072 (9.151829%)
   constants     = 576 (0.000791%)
   main code     = 58382064 (80.188637%)
   stub code     = 5310688 (7.294310%)
   oops          = 513712 (0.705591%)
   metadata      = 3377472 (4.639009%)
 immutable data  = 31596216 (28.448351%)
   dependencies  = 630760 (1.996315%)
   nul chk table = 790424 (2.501641%)
   handler table = 181552 (0.574600%)
   scopes pcs    = 16425728 (51.986378%)
   scopes data   = 13567752 (42.941067%)
 mutable data    = 6663072 (5.999244%)
Statistics for 8168 bytecoded nmethods for C2:
 total size      = 63557016 (100%)
 in CodeCache    = 27389224 (43.093945%)
   header        = 2025664 (7.395843%)
   relocation    = 3363144 (12.279078%)
   constants     = 704 (0.002570%)
   main code     = 19860704 (72.512840%)
   stub code     = 2490304 (9.092277%)
   oops          = 293760 (1.072539%)
   metadata      = 2718088 (9.923932%)
 immutable data  = 32804648 (51.614521%)
   dependencies  = 872000 (2.658160%)
   nul chk table = 519232 (1.582800%)
   handler table = 1593032 (4.856117%)
   scopes pcs    = 16690832 (50.879471%)
   scopes data   = 13129552 (40.023449%)
 mutable data    = 3363144 (5.291539%)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21276/head:pull/21276
$ git checkout pull/21276

Update a local copy of the PR:
$ git checkout pull/21276
$ git pull https://git.openjdk.org/jdk.git pull/21276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21276

View PR using the GUI difftool:
$ git pr show -t 21276

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21276.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@bulasevich The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant