Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341191: Open source few more AWT FileDialog tests #21277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Oct 1, 2024

AWT File Dialog related tests are converted from applet to manual and moved to open.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341191: Open source few more AWT FileDialog tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21277/head:pull/21277
$ git checkout pull/21277

Update a local copy of the PR:
$ git checkout pull/21277
$ git pull https://git.openjdk.org/jdk.git pull/21277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21277

View PR using the GUI difftool:
$ git pr show -t 21277

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21277.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs


public class PathChoiceDisposeTest {
public static void main(String[] args) throws Exception {
System.setProperty("sun.awt.disableGtkFileDialogs","true");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
System.setProperty("sun.awt.disableGtkFileDialogs","true");
System.setProperty("sun.awt.disableGtkFileDialogs", "true");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants