Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342299: Document that jpackage includes (possibly old) VC Redistributable MSVCP140.dll from JDK #22209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Nov 18, 2024

jpackage man page update


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8342299: Document that jpackage includes (possibly old) VC Redistributable MSVCP140.dll from JDK (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22209/head:pull/22209
$ git checkout pull/22209

Update a local copy of the PR:
$ git checkout pull/22209
$ git pull https://git.openjdk.org/jdk.git pull/22209/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22209

View PR using the GUI difftool:
$ git pr show -t 22209

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22209.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342299: Document that jpackage includes (possibly old) VC Redistributable MSVCP140.dll from JDK

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 5cb0d43: 8293040: Argfile documentation for java launcher tool is confusing regarding usage of wildcards
  • 8d43e0d: 8344331: SM cleanup in java.scripting
  • f636674: 8344247: Move objectWaiter field to VirtualThread instance
  • de6e013: 8344310: Remove Security Manager dependencies from javax.crypto and com.sun.crypto packages
  • 92271af: 8344058: Remove doPrivileged calls from macos platform sources in the java.desktop module
  • 70eb95f: 8344187: Remove SecurityManager and related calls from java.instrument
  • 922b12f: 8344078: Remove security manager dependency in java.nio
  • 2649406: 8344352: 32-bit builds crash after JDK-8305895
  • e9e4200: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry
  • c59adf6: 8344330: Remove AccessController.doPrivileged() from jdk.charsets module
  • ... and 7 more: https://git.openjdk.org/jdk/compare/dfddbcaab886b9baa731cd748bb7f547e1903b64...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev ptal

@mlbridge
Copy link

mlbridge bot commented Nov 18, 2024

Webrevs

Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants