Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344458: [11u] Add initial support for building with XCode 14 #2966

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Nov 18, 2024

An implementation of JDK-8344458 that adds conditional support for building on macos with XCode 14 while keeping compatibility with previous XCode versions.

The PR is separated in three commits for easier review:

  • First commit adds a new --enable-xcode14 configuration flag (which is currently disabled in GHA) and two additional variables:
    • CFLAGS_XCODE14_DEPR_DECLARATIONS (empty on current XCode versions, set to and -Wno-deprecated-declarations when --enable-xcode14is used)
    • And CFLAGS_XCODE14_DEPR_NON_PROTOTYPE (empty on current XCode versions, set to -Wno-deprecated-non-prototype when --enable-xcode14 is used).
  • The second commit applies CFLAGS_XCODE14_DEPR_DECLARATIONS to those parts of the codebase that use the deprecated sprintf function (i.e., avoiding sprintf usage errors in XCode 14).
  • The third commit applies CFLAGS_XCODE14_DEPR_NON_PROTOTYPE to those parts of AWT lib that generate a compilation error (i.e., avoiding the passing arguments to a function without prototype).

Since the new flag --enable-xcode14 is not set the build should run exactly the same on the current XCode versions and, consequently, the GitHub checks should pass on all platforms, including the current macos-12 & XCode 13.4.1.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8344458 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8344458: [11u] Add initial support for building with XCode 14 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2966/head:pull/2966
$ git checkout pull/2966

Update a local copy of the PR:
$ git checkout pull/2966
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2966/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2966

View PR using the GUI difftool:
$ git pr show -t 2966

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2966.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2024

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Nov 18, 2024

NOTE: The GHA macos-12 runners have been shut-down between November 18, 14:00 UTC and November 19, 00:00 UTC and are currently unavailable. The tests will be re-run when again available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant