8344458: [11u] Add initial support for building with XCode 14 #2966
+37
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of JDK-8344458 that adds conditional support for building on
macos
withXCode 14
while keeping compatibility with previousXCode
versions.The PR is separated in three commits for easier review:
--enable-xcode14
configuration flag (which is currently disabled in GHA) and two additional variables:CFLAGS_XCODE14_DEPR_DECLARATIONS
(empty on current XCode versions, set to and-Wno-deprecated-declarations
when--enable-xcode14
is used)CFLAGS_XCODE14_DEPR_NON_PROTOTYPE
(empty on current XCode versions, set to-Wno-deprecated-non-prototype
when--enable-xcode14
is used).CFLAGS_XCODE14_DEPR_DECLARATIONS
to those parts of the codebase that use the deprecatedsprintf
function (i.e., avoidingsprintf
usage errors in XCode 14).CFLAGS_XCODE14_DEPR_NON_PROTOTYPE
to those parts of AWT lib that generate a compilation error (i.e., avoiding thepassing arguments to a function without prototype
).Since the new flag
--enable-xcode14
is not set the build should run exactly the same on the current XCode versions and, consequently, the GitHub checks should pass on all platforms, including the currentmacos-12
&XCode 13.4.1
.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2966/head:pull/2966
$ git checkout pull/2966
Update a local copy of the PR:
$ git checkout pull/2966
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2966/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2966
View PR using the GUI difftool:
$ git pr show -t 2966
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2966.diff
Using Webrev
Link to Webrev Comment