8313626: C2 crash due to unexpected exception control flow

[mrserb]

Hi all,

This pull request contains a backport of commit f8203cb2 from the openjdk/jdk repository.

The commit being backported was authored by Tobias Holenstein on 23 Aug 2023 and was reviewed by Tobias Hartmann and Christian Hagedorn.

The patch is mostly clean. The jdk8u still widely uses "#ifndef PRODUCT/#endif" in the context. The usage of that macro was deleted by the next patch in jdk9: openjdk/jdk@6896030#diff-2797e2c78bff502b5d98cab2383791529d267cfd3099575872c756fcd715e143L858

• No new issues were found by the tier1 and tier2 tests.
• The new test passes before and after the patch, same as for jdk11u, see:

https://bugs.openjdk.org/browse/JDK-8313626?focusedId=14608649&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14608649

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8313626 needs maintainer approval

Issue

• JDK-8313626: C2 crash due to unexpected exception control flow (Bug - P3 - Approved)

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/581/head:pull/581
$ git checkout pull/581

Update a local copy of the PR:
$ git checkout pull/581
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/581/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 581

View PR using the GUI difftool:
$ git pr show -t 581

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/581.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8313626: C2 crash due to unexpected exception control flow

Reviewed-by: yan, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mrserb]

The failed tests:

• Linux x86: "gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java" was reported in https://bugs.openjdk.org/browse/JDK-8303159, the same failure can be found in the next PR
• macOS x64: "compiler/unsafe/OpaqueAccesses.java" was reported in https://bugs.openjdk.org/browse/JDK-8337185
• macOS x64: "com/sun/jdi/PrivateTransportTest.sh " was reported in https://bugs.openjdk.org/browse/JDK-8340660
• macOS x64: "sun/misc/CopyMemory.java" was not reported yet? but the same failure can be found in the next PR

[mlbridge]

Webrevs

• 00: Full (82de5421)

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[gnu-andrew]

Backport looks good to me. Please apply for approval.

[gnu-andrew]

/approve yes

[gnu-andrew]

The failed tests:

* Linux x86: "gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java" was reported in https://bugs.openjdk.org/browse/JDK-8303159, the same failure can be found in the next [PR](https://github.com/openjdk/jdk8u-dev/pull/571)

* macOS x64: "compiler/unsafe/OpaqueAccesses.java" was reported in https://bugs.openjdk.org/browse/JDK-8337185

* macOS x64: "com/sun/jdi/PrivateTransportTest.sh " was reported in https://bugs.openjdk.org/browse/JDK-8340660

* macOS x64: "sun/misc/CopyMemory.java" was not reported yet? but the same failure can be found in the next [PR](https://github.com/openjdk/jdk8u-dev/pull/571)

Thanks for tracking these down, by the way. We should look at resolving them in some way after the security update.

[openjdk]

@gnu-andrew
8313626: The approval request has been approved.

[mrserb]

/integrate

[openjdk]

Going to push as commit c531e47.

[openjdk]

@mrserb Pushed as commit c531e47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.