Skip to content

Commit

Permalink
add Lukas as contributor, bump up version, polish news
Browse files Browse the repository at this point in the history
  • Loading branch information
danielinteractive committed Sep 27, 2024
1 parent 9ec8a65 commit 06b3075
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
4 changes: 3 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: mmrm
Title: Mixed Models for Repeated Measures
Version: 0.3.13.9001
Version: 0.3.14
Authors@R: c(
person("Daniel", "Sabanes Bove", , "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0002-0176-9239")),
Expand All @@ -18,6 +18,8 @@ Authors@R: c(
person("Daniel", "Leibovitz", , "[email protected]", role = "aut"),
person("Daniel D.", "Sjoberg", , "[email protected]", role = "aut",
comment = c(ORCID = "0000-0003-0862-2018")),
person("Lukas A.", "Widmer", , role = "ctb",
comment = c(ORCID = "0000-0003-1471-3493")),
person("Boehringer Ingelheim Ltd.", role = c("cph", "fnd")),
person("Gilead Sciences, Inc.", role = c("cph", "fnd")),
person("F. Hoffmann-La Roche AG", role = c("cph", "fnd")),
Expand Down
6 changes: 3 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# mmrm 0.3.13.9001
# mmrm 0.3.14

### Bug Fixes

- In version 0.3.13, when the tape optimizer from `TMB` was switched on, a warning would be given by `fit_mmrm()`, instructing users to turn off the tape optimizer. However, this is not necessary for reproducible results. Instead, it is now checked whether the deterministic hash for the TMB tape optimizer is used, and a warning is issued otherwise.
- In version 0.3.13, the above described warning by `fit_mmrm()` was not visible to the user when calling `mmrm()` because it was caught internally, causing the first fit in each session to fail for the first tried optimizer and falling back to the other optimizers. The warning is now issued directly by `mmrm()`. This change ensures that the first fit is consistent with subsequent fits, avoiding discrepancies observed in version 0.3.13.
- In version 0.3.13, when the tape optimizer from `TMB` was switched on, a warning would be given by `fit_mmrm()`, instructing users to turn off the tape optimizer. However, this is not necessary for reproducible results. Instead, it is now checked whether the deterministic hash for the `TMB` tape optimizer is used, and a warning is issued otherwise.
- In version 0.3.13, the above described warning by `fit_mmrm()` was not visible to the user when calling `mmrm()` because it was caught internally, causing the first fit in each session to fail for the first tried optimizer and falling back to the other optimizers. The warning is now issued directly by `mmrm()`. This change ensures that the first model fit is consistent regarding the chosen optimizer (and thus numeric results) with subsequent model fits, avoiding discrepancies observed in version 0.3.13.

# mmrm 0.3.13

Expand Down
1 change: 1 addition & 0 deletions man/mmrm-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 06b3075

Please sign in to comment.