Update build.sh #18
Open
Update build.sh #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you install swig using the package manager, it is not detected in Ubuntu since it is looking for it in ~/swig/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ubuntu 22.04, you can install swig 4.0.2 using the package manager, but the current approach is only detecting swig installed in ~/swig. With these changes, it can work following both approaches.
Brief summary of changes
I've modified the script in a way that first checks if swig 4.0.2 has been installed using the package manager. If so, it uses it. If it has not been installed using the package manager, it follows the same approach as before.
Testing I've completed
This has passed CI in my fork (which proves it works if swig is installed manually inside of ~/swig) and in my local computer (which proves it works using the swig installed using the package manager).
Looking for feedback on...
Is the SWIG_EXE_SPEC path correct in mac? The current path assigned is the one established by default before my changes.