Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated linux build script. #3489

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Updated linux build script. #3489

merged 4 commits into from
Jun 28, 2023

Conversation

AlbertoCasasOrtiz
Copy link
Contributor

@AlbertoCasasOrtiz AlbertoCasasOrtiz commented Jun 21, 2023

Fixes issue #3488

Brief summary of changes

Added swig 4.1.1 instead of old version 4.0.2.

Testing I've completed

  • Run script in Ubuntu 22.04 and execute.
  • Run script in Ubuntu 20.04 and execute.
  • Run script in Ubuntu 18.04 and execute.
  • Run script in Debian 10 and execute.
  • Run script in Debian 11 and execute.
  • Run script in MacOS 11 and execute.
  • Run script in MacOS 12 and execute.
  • Run script in MacOS 13 and execute.
  • Run script in Windows 10 and execute.
  • Run script in Windows 11 and execute.

Looking for feedback on...

I'll may need help with testing in MacOS.

CHANGELOG.md (choose one)

  • no need to update because this is just an update to build scripts and documentation.

This change is Reviewable

@AlbertoCasasOrtiz AlbertoCasasOrtiz self-assigned this Jun 21, 2023
@AlbertoCasasOrtiz
Copy link
Contributor Author

AlbertoCasasOrtiz commented Jun 22, 2023

Current problem is that python cannot be found in windows in the script. This is because when installing using chocolatey, the environment of powershell is not refreshed (and that is why some tools like git have to be called using the full path). If you restart powershell and call the script again, it works normally.

This looks like a good solution that would allow to detect python, and get rid of full paths when calling commands that you just installed: https://stackoverflow.com/a/46760714/12928292

@adamkewley
Copy link
Contributor

Seems reasonable enough 👍

@AlbertoCasasOrtiz AlbertoCasasOrtiz changed the title WIP - Updated linux build script. Updated linux build script. Jun 28, 2023
@AlbertoCasasOrtiz
Copy link
Contributor Author

I have finally tested in every of the listed OS. For Mac, I tested using GitHub actions as Nick suggested.

@aymanhab aymanhab merged commit 6919b28 into main Jun 28, 2023
1 of 6 checks passed
@aymanhab aymanhab deleted the updating-swig-scripts-doc branch June 28, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants