Cleanup: Muscle state estimate return type in Millard2012QuilibriumMuscle
#3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the std::map<...>, which was the return type of `Millard2012EquilibriumMuscle::estimateMuscleFiberState`
MuscleStateEstimatorResult to MuscleStateEstimate and member fields in OpenSim style.
adamkewley
reviewed
Jun 28, 2023
|
@adamkewley thanks for your comments! @tkuchida , @mjhmilla , @nickbianco, care to take a look? |
tkuchida
reviewed
Jun 30, 2023
|
I'll take a look once my conference presentation drafts are ready. Hopefully sometime next week. |
nickbianco
reviewed
Jun 30, 2023
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a struct for capturing the output of the internal function
Millard2012QuilibriumMuscle::estimateMuscleFiberState.Previously the output was stored in a
std::pair, with the second field astd::map. This made it less clear what exactly the returned values are. Since the returned information was always the same, this PR adds a struct to hold it.Brief summary of changes
Adds
MuscleStateEstimateto capture the output ofMillard2012QuilibriumMuscle::estimateMuscleFiberState.Testing I've completed
Visual verification that Rajagopal model simulation gives same result before and after change.
Passed the unit tests.
CHANGELOG.md
This change is