Add bounds-checking to ObjectProperty and appropriate tests against r… #3554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3347
Brief summary of changes
.at
to add bounds-checking toOpenSim::ObjectProperty
, so that mis-indexing into one (e.g. by callingget_property()
or similar) causes a runtime exception rather than a segfaulttestComponentInterface.cpp
andtestConstraints.cpp
to ensure the behavior doesn't regressTesting I've completed
testConstraints.cpp
testComponentInterface.cpp
SimpleProperty
one did not segfault, because it was fixed in Patched segfault from reading invalid osim data (#3409) #3411ObjectProperty
one did segfaultObject.h
(i.e. swap index accessors for.at
)Looking for feedback on...
CHANGELOG.md
This change is