Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert testComponentInterface.cpp to use catch (#3555) #3563

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Convert testComponentInterface.cpp to use catch (#3555) #3563

merged 1 commit into from
Sep 25, 2023

Conversation

adamkewley
Copy link
Contributor

@adamkewley adamkewley commented Sep 25, 2023 •
edited by aymanhab
Loading

Fixes issue #3555

The disabled test is disabled because the original code commented out the callsite in main.

This change is Reviewable

tkuchida
tkuchida reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@tkuchida tkuchida left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure whether 2 additions were intentional (commented below) or perhaps I'm misreading the diff.

OpenSim/Common/Test/testComponentInterface.cpp Show resolved Hide resolved
OpenSim/Common/Test/testComponentInterface.cpp Show resolved Hide resolved
@adamkewley adamkewley merged commit 3b4cc27 into main Sep 25, 2023
6 checks passed
@adamkewley
Copy link
Contributor Author

Thanks @tkuchida !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkuchida tkuchida tkuchida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamkewley @tkuchida