Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change testGCVSpline to use catch (#3555) #3564

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Change testGCVSpline to use catch (#3555) #3564

merged 1 commit into from
Sep 25, 2023

Conversation

adamkewley
Copy link
Contributor

@adamkewley adamkewley commented Sep 25, 2023 •
edited by aymanhab
Loading

Fixes issue #3555

This change is Reviewable

tkuchida
tkuchida approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@tkuchida tkuchida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/opensim-org/opensim-core/pull/3564/files?w=1

@adamkewley
Copy link
Contributor Author

https://github.com/opensim-org/opensim-core/pull/3564/files?w=1

This is a better diff, yeah - the un-indenting of the try block makes this uglier than it needs to be!

@nickbianco nickbianco merged commit c499f0e into main Sep 25, 2023
6 checks passed
@nickbianco nickbianco deleted the change_testGCVSpline-to-catch branch September 25, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkuchida tkuchida tkuchida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamkewley @tkuchida @nickbianco