Improve bindings c3dexport #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumn data, address feedback on PR regarding naming and comments
aymanhab
added a commit
that referenced
this pull request
Oct 30, 2023
* Update c3dExport.m per suggestions in issue 3501, fix marker data conversion * Improve bindings c3dexport (#3591) * add meta data setter for table into bindings * Add methods to bindings to allow columndata scaling and to set units in metadata * undo partial fix to meta data, utilize newly exposed mul_assign for column data, address feedback on PR regarding naming and comments * Address feedback on PR, remove deadcode and update comments * Rename method intrduced in bindings to multiplyAssign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3501
Brief summary of changes
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is