Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 4.5 #3624

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Update version to 4.5 #3624

merged 1 commit into from
Nov 23, 2023

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Nov 22, 2023

Fixes issue #0

Brief summary of changes

Upgrade opensim release version to 4.5 to handle downstream effects, branching and tagging to follow

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...
  • updated.

This change is Reviewable

@aymanhab
Copy link
Member Author

@nickbianco would be good to merge this version change so we can get the version correctly downstream in conda packages and the gui

Copy link
Member

@nickbianco nickbianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just double checking: you're not creating the 4.5 tag yet, correct? Since we have a few more changes to merge.

@aymanhab
Copy link
Member Author

Indeed no tag yet, we typically create a branch for fixes post release candidate and then create a tag when all is frozen/finalized.

@aymanhab aymanhab merged commit 34c64a0 into main Nov 23, 2023
6 checks passed
@aymanhab aymanhab deleted the version_update_45 branch November 23, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants