Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3924
Brief summary of changes
String to Decimal Conversion
The above fixed the reading/writing problems but the code was still failing. Even with the imbuing of the input and output file stream, the parser converting strings to decimals is still using the system locale. After enough digging and exploration I found that
std::stod
is locale dependent. It is a thinly veiled wrapper ofstd::strtod
which does mention the locale dependance. To fix this issue I did the following:std::stod
in theIO.h
classstd::stod
with the newIO::stod
methodTesting I've completed
Looking for feedback on...
Fast_Float
Source
The two options for replacing
std::stod
are:isstream
method (standard c++):fast_float
In my preliminary testing on my machine against the three methods I got these results for program runtime:
I conducted these tests using the sample program linked above. I don't see a reason to not use the fast library but if there is opposition to including another library the
istringstream
method would also work.CHANGELOG.md (choose one)
This change is