Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to file browser cascade dialog in Id output directory selec… #1520

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Sep 26, 2024

…tion, and safeguard against null description elsewhere

Fixes issue #1519

Brief summary of changes

Filebrowser was throwing because description was passed to it as null due to upstream changes. Guarded against null description and provided an actual description for ID tool output folder browser.

Testing I've completed

CHANGELOG.md (choose one)

  • updated...

…tion, and safeguard against null description elsewhere
Describe 1519 issue/fix
@aymanhab
Copy link
Member Author

aymanhab commented Oct 9, 2024

@AlbertoCasasOrtiz for your review

Copy link
Contributor

@AlbertoCasasOrtiz AlbertoCasasOrtiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it on Windows 11 and its working as expected

LGTM!

@aymanhab
Copy link
Member Author

Thanks @AlbertoCasasOrtiz

@aymanhab aymanhab merged commit 38d9a37 into main Oct 11, 2024
3 checks passed
@aymanhab aymanhab deleted the fix_filebrowser_exception branch October 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants