[WIP] Add more thorough DGF equilibrium test. #466
+548
−388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can change the target branch of this PR as necessary. |
chrisdembia
changed the title
|
@chrisdembia I'm resurrecting this PR to push towards supporting explicit dynamics. I'm planning to change the target branch to master soon, after I sort out updating the branch locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch holds the start of a test to ensure that we can solve for muscle equilibrium throughout the desired range of muscle-tendon lengths. This includes handling buckling correctly. I think we should ensure we handle computing equilibrium before we attempt forward simulation. If the muscle cannot equilibrate at a given state, then we cannot expect to forward-integrate from that state.
I think this work might take some time to get right, and I would prefer to not hold up the preprint for this work.
This change is