Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call generateDecorations twice for fixed and non-fixed geometry #93

Merged
merged 7 commits into from
Sep 20, 2023
Merged

Call generateDecorations twice for fixed and non-fixed geometry #93

merged 7 commits into from
Sep 20, 2023

Conversation

aymanhab
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Sep 14, 2023 •
edited
Loading

✅ Deploy Preview for comforting-speculoos-d9e100 ready!

Name Link
🔨 Latest commit 2f8f21f
🔍 Latest deploy log https://app.netlify.com/sites/comforting-speculoos-d9e100/deploys/6504b51c7e787a0008573569
😎 Deploy Preview https://deploy-preview-93--comforting-speculoos-d9e100.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aymanhab
Update convertOsim2Gltf.py
4228ae7 
Clarifying comments

Signed-off-by: Ayman Habib <[email protected]>
@aymanhab
Copy link
Member Author

Contact and wrapping surfaces were not displayed because generateDecorations must be called twice on the model. Now fixed but we exclude GeometryPath as not ready to handle yet

@aymanhab
Copy link
Member Author

We can use a few more layers for Contact and Wrapping and muscles for finer grain control at some point

@aymanhab
Copy link
Member Author

@AlbertoCasasOrtiz for your review when u have a chance. Thank you

@aymanhab
Copy link
Member Author

Need to update i18n for spanish

AlbertoCasasOrtiz
AlbertoCasasOrtiz requested changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@AlbertoCasasOrtiz AlbertoCasasOrtiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aymanhab, everything seems to work properly. The only thing I detected is that if you import a new model, and try to select any object manually, it is not being selected. However if you do it from the tree, it works.

@aymanhab
Copy link
Member Author

aymanhab commented Sep 19, 2023 •
edited
Loading

Thanks @AlbertoCasasOrtiz please open an issue and I'll address with the cleanup when switching models (issue #87) If you agree, please approve this PR once the new issue is created. Thank you

@aymanhab
Copy link
Member Author

Issue #96 has been added to address selection, which is unrelated to this PR. If you agree @AlbertoCasasOrtiz please approve this PR. Thank you

AlbertoCasasOrtiz
AlbertoCasasOrtiz approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@AlbertoCasasOrtiz AlbertoCasasOrtiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aymanhab
Copy link
Member Author

Thanks @AlbertoCasasOrtiz

@aymanhab aymanhab merged commit 65476e6 into master Sep 20, 2023
5 of 6 checks passed
@aymanhab aymanhab deleted the fix_decorations branch September 20, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertoCasasOrtiz AlbertoCasasOrtiz AlbertoCasasOrtiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanhab @AlbertoCasasOrtiz