Masks off unused translation keys in activerecord #5242
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenad-vujicic
force-pushed
the
issue_remove_unused_translations_in_activerecords
branch
from
a0cc4d4
to
8c90725
Compare
|
Is this really an improvement though? We're hard coding something that rails does for us automatically in order to keep i18n-tasks happy - is that a good thing? |
Adds activerecord.errors.models.user_mute.{attributes.subject.format, is_already_muted} under ignore_unused (in i18n-tasks.yml) so they are not reported as unused anymore.
nenad-vujicic
force-pushed
the
issue_remove_unused_translations_in_activerecords
branch
from
8c90725
to
f862880
Compare
nenad-vujicic
changed the title
|
I agree, thanks. Honestly, I couldn't decide which one I didn't like more, hardcoding translating or adding to ignore list in i18n-tasks.yml (the latest commit). Is there a better way to solve this, or should this translation remain reported as unused? |
|
I was also wondering about this. IMHO the right place to address this issue would be a proper parser in https://github.com/glebm/i18n-tasks, which is able to handle model validation error messages. I didn't find anything in there, maybe we could raise an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR replaces .is_already_muted with I18n.t("activerecord.errors.models.user_mute.is_already_muted") in user_mute.rb and adds activerecord.errors.models.user_mute.attributes.subject.format under ignore_unused (in i18n-tasks.yml) since used for formatting above validation error message, so they are not reported as unused anymore.