Updates "btcli w set-identity" #146
Open
+157
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ibraheem-opentensor
commented
Oct 1, 2024
ibraheem-opentensor
commented
- Prompt the user for all fields (including sample for pgp)
- Display all fields are optional
- Explicitly asks which identity to update
- Adds checks for each identity update use-case
- Moves get_hotkey_owner to subtensor_interface
thewhaleking
approved these changes
Oct 2, 2024
Comment on lines
+2101
to
+2143
| if not any( | ||
| [ | ||
| display_name, | ||
| legal_name, | ||
| web_url, | ||
| riot_handle, | ||
| email, | ||
| pgp_fingerprint, | ||
| image_url, | ||
| info_, | ||
| twitter_url, | ||
| ] | ||
| ): | ||
| console.print("[yellow]All fields are optional. Press Enter to skip a field.[/yellow]") | ||
|
|
||
| display_name = display_name or typer.prompt( | ||
| "Display name", default="", show_default=False | ||
| ) | ||
| legal_name = legal_name or typer.prompt( | ||
| "Legal name", default="", show_default=False | ||
| ) | ||
| web_url = web_url or typer.prompt( | ||
| "Web URL", default="", show_default=False | ||
| ) | ||
| riot_handle = riot_handle or typer.prompt( | ||
| "Riot handle", default="", show_default=False | ||
| ) | ||
| email = email or typer.prompt( | ||
| "Email address", default="", show_default=False | ||
| ) | ||
| pgp_fingerprint = pgp_fingerprint or typer.prompt( | ||
| "PGP fingerprint (Eg: A1B2 C3D4 E5F6 7890 1234 5678 9ABC DEF0 1234 5678)", | ||
| default="", | ||
| show_default=False, | ||
| ) | ||
| image_url = image_url or typer.prompt( | ||
| "Image URL", default="", show_default=False | ||
| ) | ||
| info_ = info_ or typer.prompt("Enter info", default="", show_default=False) | ||
| twitter_url = twitter_url or typer.prompt( | ||
| "Twitter (𝕏) URL", default="", show_default=False | ||
| ) | ||
|
|
There was a problem hiding this comment.
We should actually be size-checking here as well, but let's leave that as a TODO feature for next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.