Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TorchFX] Bias correction implementation #2882

Merged
merged 7 commits into from
Aug 30, 2024
Merged

[TorchFX] Bias correction implementation #2882

merged 7 commits into from
Aug 30, 2024

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Aug 12, 2024 •
edited
Loading

Changes

TorchFX bias correction implementation

Reason for changes

To improve accuracy of sensitive quantized models

Related tickets

#2766

Tests

  • test_bias_correction template is implemented for TorchFX
  • post_training_quantization/473/ is successful

@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch experimental NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX NNCF PTQ Pull requests that updates NNCF PTQ labels Aug 13, 2024
@daniil-lyakhov daniil-lyakhov changed the title WIP [TorchFX] Bias correction implementation [TorchFX] Bias correction implementation Aug 20, 2024
@daniil-lyakhov daniil-lyakhov marked this pull request as ready for review August 20, 2024 14:17
@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner August 20, 2024 14:17
KodiaqQ
KodiaqQ reviewed Aug 22, 2024
View reviewed changes
nncf/experimental/torch/fx/model_transformer.py Outdated Show resolved Hide resolved
nncf/experimental/torch/fx/model_transformer.py Outdated Show resolved Hide resolved
nncf/experimental/torch/fx/nncf_graph_builder.py Outdated Show resolved Hide resolved
nncf/experimental/torch/fx/nncf_graph_builder.py Outdated Show resolved Hide resolved
nncf/experimental/torch/fx/node_utils.py Outdated Show resolved Hide resolved
nncf/quantization/algorithms/bias_correction/torch_fx_backend.py Show resolved Hide resolved
nncf/quantization/algorithms/bias_correction/torch_fx_backend.py Show resolved Hide resolved
nncf/quantization/algorithms/bias_correction/torch_fx_backend.py Show resolved Hide resolved
nncf/torch/graph/operator_metatypes.py Show resolved Hide resolved
tests/post_training/model_scope.py Show resolved Hide resolved
@daniil-lyakhov daniil-lyakhov mentioned this pull request Aug 26, 2024
Merged
AlexanderDokuchaev
AlexanderDokuchaev requested changes Aug 28, 2024
View reviewed changes
nncf/experimental/torch/fx/model_transformer.py Show resolved Hide resolved
nncf/experimental/torch/fx/model_transformer.py Outdated Show resolved Hide resolved
nncf/experimental/torch/fx/model_transformer.py Outdated Show resolved Hide resolved
nncf/experimental/torch/fx/model_transformer.py Show resolved Hide resolved
nncf/experimental/torch/fx/model_transformer.py Show resolved Hide resolved
tests/post_training/data/ptq_reference_data.yaml Outdated Show resolved Hide resolved
tests/post_training/model_scope.py Show resolved Hide resolved
nncf/quantization/algorithms/bias_correction/torch_fx_backend.py Show resolved Hide resolved
nncf/quantization/algorithms/bias_correction/torch_fx_backend.py Show resolved Hide resolved
nncf/quantization/algorithms/fast_bias_correction/torch_fx_backend.py Show resolved Hide resolved
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 29, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Aug 29, 2024
@AlexanderDokuchaev AlexanderDokuchaev merged commit aa37119 into openvinotoolkit:develop Aug 30, 2024
13 checks passed
@alexsu52 alexsu52 mentioned this pull request Oct 9, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodiaqQ KodiaqQ KodiaqQ approved these changes

@AlexanderDokuchaev AlexanderDokuchaev AlexanderDokuchaev approved these changes

@anzr299 anzr299 Awaiting requested review from anzr299

Assignees
No one assigned
Labels
experimental NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniil-lyakhov @KodiaqQ @AlexanderDokuchaev