[NVIDIA] Add CUDNN_INCLUDE_DIR
#831
Open
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: build
vurusovs
commented
Jan 17, 2024
| @@ -51,6 +51,7 @@ target_include_directories(${OBJ_NAME} | |||
| ) | |||
| target_include_directories(${OBJ_NAME} | |||
| PUBLIC | |||
| "${CUDNN_INCLUDE_DIR}" | |||
There was a problem hiding this comment.
@ilya-lavrenov could you take a look? Without it cudnn.h wasn't found even if I specified INTERFACE_INCLUDE_DIRECTORIES "${CUDNN_INCLUDE_DIR}"
There was a problem hiding this comment.
It's strange because we have linkage with CUDA::cutensor below and it should populate headers we set before.
But let's avoid spending extra time on it :)
ilya-lavrenov
approved these changes
Jan 17, 2024
| @@ -92,6 +92,8 @@ find_library(CUDNN_PATH | |||
| ${HAS_REQUIRED} | |||
| HINTS "$ENV{CUDNN_PATH}" "${CUDA_TOOLKIT_ROOT_DIR}" "${CUDA_PATH}" "$ENV{CUDA_PATH}" | |||
| PATH_SUFFIXES nvidia/current lib64 lib/x64 lib) | |||
| get_filename_component(CUDNN_INCLUDE_DIR "${CUDNN_PATH}" DIRECTORY) | |||
| get_filename_component(CUDNN_INCLUDE_DIR "${CUDNN_INCLUDE_DIR}/../../include" REALPATH) | |||
There was a problem hiding this comment.
Looks like we need to find headers instead of simple relative paths..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.