dnsdist: Add UCI integration, better defaults #25398
Open
+1,864
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port Signed-off-by: Remi Gacogne <[email protected]>
Habbie
suggested changes
Nov 18, 2024
Signed-off-by: Remi Gacogne <[email protected]>
Oops, good one! Done. |
Habbie
approved these changes
Nov 18, 2024
dwfreed
reviewed
Nov 18, 2024
net/dnsdist/Makefile
Outdated
Comment on lines
87
to
97
| define Package/dnsdist/postinst/Default | ||
| #!/bin/sh | ||
| # if we are on a "real" system, IPKG_INSTROOT will be empty, | ||
| # otherwise we are in the process of building an image and | ||
| # thus on the host system | ||
| local root="$${IPKG_INSTROOT}" | ||
|
|
||
| if [ ! -e "$${root}/etc/config/dnsdist" ]; then | ||
| cp "$${root}/usr/share/dnsdist/simple.uci.conf" "$${root}/etc/config/dnsdist" | ||
| fi | ||
| endef |
There was a problem hiding this comment.
I don't think this needs to be a postinst. Conffile handling will ensure that a user's config is not overwritten. The $(INSTALL_CONF) that was removed should work just fine.
There was a problem hiding this comment.
Thanks! Given that neither Habbie nor I can remember why we introduced this change, I'm going to sleep on it and very likely revert it tomorrow :)
There was a problem hiding this comment.
I just pushed a commit reverting this change, thanks!
Signed-off-by: Remi Gacogne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me / @Habbie
Compile tested: github actions
Run tested: x86_64 docker and TP-Link Archer C7 AC1750 v5 (pre-APK, though)
Description:
This pull request adds UCI integration for DNSdist, making it possible to configure a fair amount of features via UCI. It includes the ability to resolve DNS queries for local domains, getting the name of local devices from the DHCP leases (which is why this PR grants the
dnsdistuser access to DHCP leases), and Discovery of Designated Resolver (DDR, RFC94621) support to signal DoT and DoH support to clients on the local network.It also tunes the default settings, using values that make more sense for routers and reduce the memory usage a lot.
Signed-off-by: Remi Gacogne [email protected]