Skip to content

Commit

Permalink
bmx7: cleanup Makefile
Browse files Browse the repository at this point in the history
  • Loading branch information
axn committed Jun 10, 2024
1 parent 055d386 commit 8d8cfe8
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions bmx7/Makefile
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=bmx7
# PKG_VERSION:=7.1.1
PKG_VERSION:=r2024051906
PKG_VERSION:=r2024061001
PKG_RELEASE:=1

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
# PKG_SOURCE_URL:=https://codeload.github.com/bmx-routing/bmx7/tar.gz/v$(PKG_VERSION)?
# PKG_HASH:=5f88df1c95e5cb842a6016bb1604e3e7f6097c63c5c9916edc3c84e96d4f5f65

PKG_SOURCE_PROTO:=git
PKG_SOURCE_URL:=https://github.com/bmx-routing/bmx7.git
PKG_SOURCE_VERSION:=9020896f89006bc5d3487222eefc7ddea9e8b2bd
PKG_MIRROR_HASH:=skip
HASH:=skip
PKG_MIRROR_HASH:=6c126c512f9b015d8ce9748cb7d04654aff544395ae0409d4e8fe4b9f6c33eba

PKG_MAINTAINER:=Axel Neumann <[email protected]>
PKG_LICENSE:=GPL-2.0-or-later
Expand Down

2 comments on commit 8d8cfe8

@PolynomialDivision
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit is missing a signed-off-line. Please use a PR instead of pushing directly to master branch, so CI can check everything.

@BKPepe
Copy link
Member

@BKPepe BKPepe commented on 8d8cfe8 Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not know why it was pushed to the master branch without proper review, etc. The same thing happpened with the previous commit as well b0f316a#commitcomment-142951885 , you haven't requested review. :-( This is not how we works, though.

Please sign in to comment.