nodogsplash: explicit file copy

[mwarning]

Maintainer: me
Compile tested: pipeline

[mwarning]

@BKPepe how is this?

[mwarning]

@BKPepe can I cherry-pick this into the other MRs for the other branches? Or do you want me to squash them?

[mwarning]

@BKPepe ping

[BKPepe]

I will look into it tomorrow. čt 19. 10. 2023 v 18:52 odesílatel Moritz Warning ***@***.***> napsal:

…

@BKPepe <https://github.com/BKPepe> ping — Reply to this email directly, view it on GitHub <#1027 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7IDVC5PBJFSXNQUKXLZD3YAFLDRAVCNFSM6AAAAAA52Z4UI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRGM3TCMRWGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[BKPepe]

This still does not look good. We are using simple CP. This needs to be reworked.

We should make it more clear, which will be more better to read this install section and it will be simple as it is.

1. Create folder, then install files to it and then create another folder and install there files, which are there.
   The order if you do first binaries, then config files, does not matter. Important is that it is not lost.

This is done for binary (a few lines above) and then you are creating three folders and it might be messy.

Anyway, I would suggest to use installation macros, which are listed here:
https://openwrt.org/docs/guide-developer/packages#file_installation_macros

E.g., INSTALL_CONF for config file, INSTALL_BIN for init config, etc.

This makes sure that it has permissions on the router, which we want and that it has not been tinkerered with.